Bug 186857

Summary: [WinCairo][Buildbot] Test bots should use same WinCairoRequirements version as the triggering build
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: Tools / TestsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, don.olmstead, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ross Kirsling
Reported 2018-06-20 11:45:52 PDT
To avoid strange test failures when WinCairoRequirements is updated, we'll want to ensure that test bots use the same version that the triggering build used. To facilitate this, we can have the "download GitHub release" script take a tag. This would also allow us to lock the version in the future, should a need arise.
Attachments
Patch (7.77 KB, patch)
2018-06-20 12:01 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2018-06-20 12:01:32 PDT
Created attachment 343173 [details] Patch
WebKit Commit Bot
Comment 2 2018-06-22 12:08:35 PDT
Comment on attachment 343173 [details] Patch Clearing flags on attachment: 343173 Committed r233088: <https://trac.webkit.org/changeset/233088>
WebKit Commit Bot
Comment 3 2018-06-22 12:08:36 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-06-22 12:09:18 PDT
<rdar://problem/41376978>
Note You need to log in before you can comment on or make changes to this bug.