Bug 186857 - [WinCairo][Buildbot] Test bots should use same WinCairoRequirements version as the triggering build
Summary: [WinCairo][Buildbot] Test bots should use same WinCairoRequirements version a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-20 11:45 PDT by Ross Kirsling
Modified: 2018-06-22 12:09 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.77 KB, patch)
2018-06-20 12:01 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2018-06-20 11:45:52 PDT 
To avoid strange test failures when WinCairoRequirements is updated, we'll want to ensure that test bots use the same version that the triggering build used.

To facilitate this, we can have the "download GitHub release" script take a tag.
This would also allow us to lock the version in the future, should a need arise.
Comment 1 Ross Kirsling 2018-06-20 12:01:32 PDT 
Created attachment 343173 [details]
Patch
Comment 2 WebKit Commit Bot 2018-06-22 12:08:35 PDT 
Comment on attachment 343173 [details]
Patch

Clearing flags on attachment: 343173

Committed r233088: <https://trac.webkit.org/changeset/233088>
Comment 3 WebKit Commit Bot 2018-06-22 12:08:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-06-22 12:09:18 PDT 
<rdar://problem/41376978>