Bug 186828

Summary: flattenDictionaryStructure needs to zero properties that have been compressed away
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing keith_miller: commit-queue+

Keith Miller
Reported 2018-06-19 17:10:42 PDT
flattenDictionaryStructure needs to zero properties that have been compressed away
Attachments
Patch (1.76 KB, patch)
2018-06-19 17:11 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.25 KB, patch)
2018-06-19 18:21 PDT, Keith Miller 		keith_miller: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2018-06-19 17:11:16 PDT
Created attachment 343122 [details] Patch
Mark Lam
Comment 2 2018-06-19 17:21:47 PDT
Comment on attachment 343122 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343122&action=review r=me > Source/JavaScriptCore/runtime/Structure.cpp:783 > + // We need to make sure we zero our unused butterfly space otherwise the GC might see a stale pointer. I think you can drop the "make sure we" part, and I suggest adding a semicolon after "space" and a comma after "otherwise".
Keith Miller
Comment 3 2018-06-19 18:21:03 PDT
Created attachment 343128 [details] Patch for landing
Keith Miller
Comment 4 2018-06-19 18:28:09 PDT
Committed r233001: <https://trac.webkit.org/changeset/233001>
Radar WebKit Bug Importer
Comment 5 2018-06-19 18:29:18 PDT
<rdar://problem/41272865>
Note You need to log in before you can comment on or make changes to this bug.