Bug 186824

Summary: [test262-runner] Reduce flakiness of unit tests for the runner
Product: WebKit Reporter: Leo Balter <leo>
Component: New BugsAssignee: Leo Balter <leo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, ews-watchlist, msaboff, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=203964
Attachments:
Description Flags
Patch none

Leo Balter
Reported 2018-06-19 15:38:44 PDT
[test262-runner] Reduce flakiness of unit tests for the runner
Attachments
Patch (2.31 KB, patch)
2018-06-19 15:39 PDT, Leo Balter 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Leo Balter
Comment 1 2018-06-19 15:39:08 PDT
Created attachment 343115 [details] Patch
Leo Balter
Comment 2 2018-06-19 15:43:29 PDT
This is after the report from https://bugs.webkit.org/show_bug.cgi?id=186443#c34 The change on the Tools/Scripts/test262/Runner.pm avoids calls to the runner without enough files. That fixes the reported problem, but running the tests locally - calling `perl ./Tools/Scripts/test-webkitperl` - I noticed some flakiness in the runner that I'm trying to minimize by setting only one process for each time the test262-runner is called. Otherwise I was getting some non matching exit codes.
Michael Saboff
Comment 3 2018-06-19 16:43:05 PDT
Comment on attachment 343115 [details] Patch r=me
WebKit Commit Bot
Comment 4 2018-06-19 17:09:34 PDT
Comment on attachment 343115 [details] Patch Clearing flags on attachment: 343115 Committed r232996: <https://trac.webkit.org/changeset/232996>
WebKit Commit Bot
Comment 5 2018-06-19 17:09:35 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-06-19 17:11:16 PDT
<rdar://problem/41270714>
Note You need to log in before you can comment on or make changes to this bug.