Bug 186824 - [test262-runner] Reduce flakiness of unit tests for the runner
Summary: [test262-runner] Reduce flakiness of unit tests for the runner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leo Balter
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-19 15:38 PDT by Leo Balter
Modified: 2018-06-19 17:11 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.31 KB, patch)
2018-06-19 15:39 PDT, Leo Balter
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Balter 2018-06-19 15:38:44 PDT
[test262-runner] Reduce flakiness of unit tests for the runner
Comment 1 Leo Balter 2018-06-19 15:39:08 PDT
Created attachment 343115 [details]
Patch
Comment 2 Leo Balter 2018-06-19 15:43:29 PDT
This is after the report from https://bugs.webkit.org/show_bug.cgi?id=186443#c34

The change on the Tools/Scripts/test262/Runner.pm avoids calls to the runner without enough files.

That fixes the reported problem, but running the tests locally - calling `perl ./Tools/Scripts/test-webkitperl` - I noticed some flakiness in the runner that I'm trying to minimize by setting only one process for each time the test262-runner is called. Otherwise I was getting some non matching exit codes.
Comment 3 Michael Saboff 2018-06-19 16:43:05 PDT
Comment on attachment 343115 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-06-19 17:09:34 PDT
Comment on attachment 343115 [details]
Patch

Clearing flags on attachment: 343115

Committed r232996: <https://trac.webkit.org/changeset/232996>
Comment 5 WebKit Commit Bot 2018-06-19 17:09:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-06-19 17:11:16 PDT
<rdar://problem/41270714>