| Summary: | Use getCurrentProcessID over getpid | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||||
| Component: | WebKit2 | Assignee: | Don Olmstead <don.olmstead> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, annulen, bfulgham, cdumez, commit-queue, ews-watchlist, mcatanzaro, rniwa, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Don Olmstead
2018-06-19 12:23:50 PDT
Created attachment 343079 [details]
Patch
Attachment 343079 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 343080 [details]
Patch
While I see the value in cross platform code, I am not convinced we should update platform-specific code. (In reply to Chris Dumez from comment #4) > While I see the value in cross platform code, I am not convinced we should > update platform-specific code. I don't have a strong opinion on that. I'm fine with removing references in the platform specific bits. Seemed like if it was there in WTF we should just use it. Created attachment 343092 [details]
Patch
Modified to just touch common code.
Comment on attachment 343092 [details] Patch Clearing flags on attachment: 343092 Committed r232988: <https://trac.webkit.org/changeset/232988> All reviewed patches have been landed. Closing bug. |