Bug 186813

Summary: Use getCurrentProcessID over getpid
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: WebKit2Assignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, cdumez, commit-queue, ews-watchlist, mcatanzaro, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Don Olmstead
Reported 2018-06-19 12:23:50 PDT
getpid is used in common code instead of getCurrentProcessID.
Attachments
Patch (6.71 KB, patch)
2018-06-19 12:33 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (6.73 KB, patch)
2018-06-19 12:37 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (3.94 KB, patch)
2018-06-19 13:47 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-06-19 12:33:34 PDT
Created attachment 343079 [details] Patch
EWS Watchlist
Comment 2 2018-06-19 12:35:49 PDT
Attachment 343079 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 3 2018-06-19 12:37:22 PDT
Created attachment 343080 [details] Patch
Chris Dumez
Comment 4 2018-06-19 12:53:52 PDT
While I see the value in cross platform code, I am not convinced we should update platform-specific code.
Don Olmstead
Comment 5 2018-06-19 13:23:57 PDT
(In reply to Chris Dumez from comment #4) > While I see the value in cross platform code, I am not convinced we should > update platform-specific code. I don't have a strong opinion on that. I'm fine with removing references in the platform specific bits. Seemed like if it was there in WTF we should just use it.
Don Olmstead
Comment 6 2018-06-19 13:47:25 PDT
Created attachment 343092 [details] Patch Modified to just touch common code.
WebKit Commit Bot
Comment 7 2018-06-19 15:02:40 PDT
Comment on attachment 343092 [details] Patch Clearing flags on attachment: 343092 Committed r232988: <https://trac.webkit.org/changeset/232988>
WebKit Commit Bot
Comment 8 2018-06-19 15:02:42 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-06-19 15:03:25 PDT
<rdar://problem/41265747>
Note You need to log in before you can comment on or make changes to this bug.