Bug 186777

Summary: Resource Load Statistics: Make sure to call callbacks even if there is no store (test infrastructure)
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, calvaris, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=183714
Attachments:
Description Flags
Patch none

John Wilander
Reported 2018-06-18 10:35:48 PDT
We have a couple of instances in WKWebsiteDataStoreRef.cpp where if there is no resource load statistics store we do an early return, like so: if (!store) return; These instances need to also call the callback if there is one. Note that these functions are used for testing and this change is part of addressing test flakiness, for instance in https://bugs.webkit.org/show_bug.cgi?id=183714.
Attachments
Patch (3.93 KB, patch)
2018-06-18 10:57 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-06-18 10:53:29 PDT
<rdar://problem/41216181>
John Wilander
Comment 2 2018-06-18 10:54:30 PDT
(For any GTK people who get notified of this bug: I accidentally chose GTK instead of Misc. Sorry about that.)
John Wilander
Comment 3 2018-06-18 10:57:52 PDT
Created attachment 342952 [details] Patch
John Wilander
Comment 4 2018-06-18 15:00:17 PDT
Comment on attachment 342952 [details] Patch Thanks, Chris!
WebKit Commit Bot
Comment 5 2018-06-18 15:27:04 PDT
Comment on attachment 342952 [details] Patch Clearing flags on attachment: 342952 Committed r232950: <https://trac.webkit.org/changeset/232950>
WebKit Commit Bot
Comment 6 2018-06-18 15:27:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.