| Summary: | Expose RTCPeerConnectionIceEventInit constructor | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, cdumez, commit-queue, eric.carlson, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2018-06-18 09:05:04 PDT
Created attachment 342944 [details]
Patch
Comment on attachment 342944 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342944&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnectionIceEvent.idl:28 > + DOMString? url; Why is this not a DOMURL? > > Source/WebCore/Modules/mediastream/RTCPeerConnectionIceEvent.idl:28
> > + DOMString? url;
>
> Why is this not a DOMURL?
I am not quite sure, it is defined in RFCs as specific URIs and I believe it could be passed as DOMURL.
But this would require changing an API that is there since quite some time with only small benefits.
Not this particular attribute but RTCIceServer which has a "DOMString url" attribute and is passed as parameter of RTCPeerConnection getter.
Created attachment 342965 [details]
Patch for landing
(In reply to youenn fablet from comment #5) > Created attachment 342965 [details] > Patch for landing Updated PeerConnectionBackend::finishedRegisteringMDNSName implementation to use more WTFMove. Comment on attachment 342965 [details] Patch for landing Clearing flags on attachment: 342965 Committed r232943: <https://trac.webkit.org/changeset/232943> All reviewed patches have been landed. Closing bug. |