Bug 186770

Summary: Expose RTCPeerConnectionIceEventInit constructor
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2018-06-18 09:05:04 PDT
Expose RTCPeerConnectionIceEventInit constructor as per spec
Attachments
Patch (29.01 KB, patch)
2018-06-18 09:13 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (28.93 KB, patch)
2018-06-18 13:08 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-06-18 09:13:25 PDT
Created attachment 342944 [details] Patch
Radar WebKit Bug Importer
Comment 2 2018-06-18 09:13:53 PDT
<rdar://problem/41212281>
Alex Christensen
Comment 3 2018-06-18 10:27:46 PDT
Comment on attachment 342944 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342944&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnectionIceEvent.idl:28 > + DOMString? url; Why is this not a DOMURL?
youenn fablet
Comment 4 2018-06-18 13:06:24 PDT
> > Source/WebCore/Modules/mediastream/RTCPeerConnectionIceEvent.idl:28 > > + DOMString? url; > > Why is this not a DOMURL? I am not quite sure, it is defined in RFCs as specific URIs and I believe it could be passed as DOMURL. But this would require changing an API that is there since quite some time with only small benefits. Not this particular attribute but RTCIceServer which has a "DOMString url" attribute and is passed as parameter of RTCPeerConnection getter.
youenn fablet
Comment 5 2018-06-18 13:08:51 PDT
Created attachment 342965 [details] Patch for landing
youenn fablet
Comment 6 2018-06-18 13:10:01 PDT
(In reply to youenn fablet from comment #5) > Created attachment 342965 [details] > Patch for landing Updated PeerConnectionBackend::finishedRegisteringMDNSName implementation to use more WTFMove.
WebKit Commit Bot
Comment 7 2018-06-18 13:48:14 PDT
Comment on attachment 342965 [details] Patch for landing Clearing flags on attachment: 342965 Committed r232943: <https://trac.webkit.org/changeset/232943>
WebKit Commit Bot
Comment 8 2018-06-18 13:48:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.