Bug 186705

Summary: StyleRuleMedia wastes 158KB of Vector capacity on cnn.com
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, koivisto, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2018-06-15 15:07:11 PDT
Tooling from bug 186698: Wasted capacity: 158008 bytes (used 16128 of 174136 bytes, utilization: 9.26%) - 1356 allocations 1 0x1074c1355 WTF::VectorBuffer<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul>::VectorBuffer() 2 0x1074c1335 WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 3 0x107497385 WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>::Vector() 4 0x1074972da WebCore::StyleRuleGroup::StyleRuleGroup(WebCore::StyleRuleBase::Type, WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>&) 5 0x1074980cd WebCore::StyleRuleMedia::StyleRuleMedia(WTF::Ref<WebCore::MediaQuerySet, WTF::DumbPtrTraits<WebCore::MediaQuerySet> >&&, WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>&) 6 0x107498125 WebCore::StyleRuleMedia::StyleRuleMedia(WTF::Ref<WebCore::MediaQuerySet, WTF::DumbPtrTraits<WebCore::MediaQuerySet> >&&, WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>&) 7 0x1074de618 WebCore::StyleRuleMedia::create(WTF::Ref<WebCore::MediaQuerySet, WTF::DumbPtrTraits<WebCore::MediaQuerySet> >&&, WTF::Vector<WTF::RefPtr<WebCore::StyleRuleBase, WTF::DumbPtrTraits<WebCore::StyleRuleBase> >, 0ul, WTF::CrashOnOverflow, 16ul>&) 8 0x1074dc1d8 WebCore::CSSParserImpl::consumeMediaRule(WebCore::CSSParserTokenRange, WebCore::CSSParserTokenRange)
Attachments
Patch (2.47 KB, patch)
2018-06-15 16:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-06-15 15:07:40 PDT
<rdar://problem/41173637>
Chris Dumez
Comment 2 2018-06-15 16:55:55 PDT
Created attachment 342857 [details] Patch
WebKit Commit Bot
Comment 3 2018-06-15 18:59:48 PDT
Comment on attachment 342857 [details] Patch Clearing flags on attachment: 342857 Committed r232899: <https://trac.webkit.org/changeset/232899>
WebKit Commit Bot
Comment 4 2018-06-15 18:59:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.