Summary: | DisplayRefreshMonitorMac should hold a weak pointer to WebPage. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, commit-queue, simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 186891 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Per Arne Vollan
2018-06-15 10:42:40 PDT
Created attachment 342828 [details]
Patch
Comment on attachment 342828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342828&action=review r=me > Source/WebKit/ChangeLog:10 > + observed in practice, but it is safer to use a weak pointer. Good point! Comment on attachment 342828 [details]
Patch
Thanks for reviewing!
Comment on attachment 342828 [details] Patch Clearing flags on attachment: 342828 Committed r232884: <https://trac.webkit.org/changeset/232884> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 186891 Committed r234725: <https://trac.webkit.org/changeset/234725/webkit> |