Bug 186675

Summary:

Rollout r231818, as it introduced regression on tickets.com.

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

WebKit Misc.

Assignee:

Per Arne Vollan <pvollan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=190884

Attachments:

Description	Flags
Patch	none

Per Arne Vollan

Reported 2018-06-15 09:56:16 PDT

Rollout https://trac.webkit.org/changeset/231818/webkit, as it introduced regression on tickets.com. This changeset would pause display links in background tasks, and when Safari is minimized. Perhaps we can throttle display links in background tabs instead? This changeset is also not needed to fix the associated bug https://bugs.webkit.org/show_bug.cgi?id=185627 anymore, since this was fixed by https://trac.webkit.org/changeset/232563.

Attachments
Patch (3.33 KB, patch) 2018-06-15 10:01 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Per Arne Vollan

Comment 1 2018-06-15 09:57:25 PDT

<rdar://problem/41103671>

Per Arne Vollan

Comment 2 2018-06-15 10:01:37 PDT

Created attachment 342821 [details] Patch

WebKit Commit Bot

Comment 3 2018-06-15 10:32:55 PDT

Comment on attachment 342821 [details] Patch Clearing flags on attachment: 342821 Committed r232879: <https://trac.webkit.org/changeset/232879>

WebKit Commit Bot

Comment 4 2018-06-15 10:32:56 PDT

All reviewed patches have been landed. Closing bug.

Simon Fraser (smfr)

Comment 5 2018-11-07 10:49:17 PST

Won't this be a power regression?

Per Arne Vollan

Comment 6 2018-11-07 13:32:47 PST

(In reply to Simon Fraser (smfr) from comment #5) > Won't this be a power regression? I don't believe so, since starting/stopping a display link is controlled by cross-platform code by creating/deleting a DisplayRefreshMonitor.

Note You need to log in before you can comment on or make changes to this bug.