| Summary: | Add a graceful exit for AuthenticationManager::initializeConnection | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||||
| Component: | WebKit Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, benjamin, bfulgham, bugs-noreply, calvaris, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, jiewen_tan, ltilve+ews, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jiewen Tan
2018-06-14 14:22:37 PDT
Created attachment 342761 [details]
Patch
Comment on attachment 342761 [details] Patch Attachment 342761 [details] did not pass gtk-wk2-ews (gtk-wk2): Output: http://webkit-queues.webkit.org/results/8189070 New failing tests: http/tests/misc/char-encoding-bocu-1-blacklisted.html Created attachment 342786 [details]
Archive of layout-test-results from ltilve-gtk-wk2-ews for gtk-wk2
The attached test failures were seen while running run-webkit-tests on the gtk-wk2-ews.
Bot: ltilve-gtk-wk2-ews Port: gtk-wk2 Platform: Linux-4.16.0-0.bpo.1-amd64-x86_64-with-debian-9.4
The tree of GTK EWS Port is red. Comment on attachment 342761 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342761&action=review r=me. > Source/WebKit/ChangeLog:3 > + Add a grace exit for AuthenticationManager::initializeConnection Add a graceful exit ... > Source/WebKit/ChangeLog:9 > + Add a grace exit for AuthenticationManager::initializeConnection when the provided IPC connection Ditto. Comment on attachment 342761 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342761&action=review Thanks Brent for r+ this patch. >> Source/WebKit/ChangeLog:3 >> + Add a grace exit for AuthenticationManager::initializeConnection > > Add a graceful exit ... Fixed. >> Source/WebKit/ChangeLog:9 >> + Add a grace exit for AuthenticationManager::initializeConnection when the provided IPC connection > > Ditto. Fixed. Created attachment 342953 [details]
Patch for landing
Comment on attachment 342953 [details] Patch for landing Clearing flags on attachment: 342953 Committed r232937: <https://trac.webkit.org/changeset/232937> |