Bug 186606

Summary: Web Inspector: open source Dark Mode
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
timothy: review+
Patch none

Description Nikita Vasilyev 2018-06-13 13:07:56 PDT 
Safari Developer Tools on macOS Mojave support a dark mode. Make it publicly available as a part of the WebKit repository.

<rdar://problem/41027067>
Comment 1 Nikita Vasilyev 2018-06-13 13:16:44 PDT 
Created attachment 342687 [details]
Patch
Comment 2 Nikita Vasilyev 2018-06-13 13:22:14 PDT 
Created attachment 342688 [details]
Patch

Add the license header.
Comment 3 Timothy Hatcher 2018-06-13 13:38:27 PDT 
Comment on attachment 342688 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342688&action=review

> Source/WebInspectorUI/UserInterface/Main.html:240
> +    <link rel="stylesheet" href="Views/DarkMode.css">

It would be good to merge the rules into the other files for ease of maintenance in a future patch.

> Source/WebInspectorUI/UserInterface/Main.html:-243
> -    <link rel="stylesheet" href="WebKitAdditions/WebInspectorUI/WebInspectorUIAdditions.css">

Might as well keep this line, in case we need it in the future.
Comment 4 Nikita Vasilyev 2018-06-13 13:47:38 PDT 
Created attachment 342690 [details]
Patch

(In reply to Timothy Hatcher from comment #3)
> Comment on attachment 342688 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342688&action=review
> 
> > Source/WebInspectorUI/UserInterface/Main.html:240
> > +    <link rel="stylesheet" href="Views/DarkMode.css">
> 
> It would be good to merge the rules into the other files for ease of
> maintenance in a future patch.

Yes, that's the plan!
Comment 5 WebKit Commit Bot 2018-06-13 14:26:41 PDT 
Comment on attachment 342690 [details]
Patch

Clearing flags on attachment: 342690

Committed r232811: <https://trac.webkit.org/changeset/232811>
Comment 6 WebKit Commit Bot 2018-06-13 14:26:43 PDT 
All reviewed patches have been landed.  Closing bug.