Bug 186582

Summary: [WinCairo] Move unrelated features of WorkQueueWin into IPC::Connection
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: PlatformAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, bfulgham, commit-queue, don.olmstead, ews-watchlist, webkit-bug-importer, youennf, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
PATCH
none
PATCH
none
FIX none

Basuke Suzuki
Reported 2018-06-12 17:21:00 PDT
The following feature is not related to WorkQueue's purpose and only used in IPC::Connection for WebKit Windows. It should be moved there until others actually need that feature. > (WTF::WorkQueue::handleCallback): > (WTF::WorkQueue::registerHandle): > (WTF::WorkQueue::unregisterAndCloseHandle):
Attachments
PATCH (20.93 KB, patch)
2018-06-13 18:03 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
PATCH (20.91 KB, patch)
2018-06-14 11:56 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
FIX (20.91 KB, patch)
2018-06-14 15:06 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-06-13 18:03:14 PDT
Created attachment 342715 [details] PATCH
EWS Watchlist
Comment 2 2018-06-13 18:04:39 PDT
Attachment 342715 [details] did not pass style-queue: ERROR: Source/WebKit/Platform/IPC/win/ConnectionWin.cpp:357: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/Platform/IPC/win/ConnectionWin.cpp:357: Missing space inside { }. [whitespace/braces] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 3 2018-06-14 00:42:07 PDT
Comment on attachment 342715 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=342715&action=review Looks nice to me. I want Windows reviewer's r+ too. > Source/WebKit/Platform/IPC/win/ConnectionWin.cpp:345 > + // Connection::platformInvalidate. => EventListener::close(). > Source/WebKit/Platform/IPC/win/ConnectionWin.cpp:348 > + // And do not ::CloseHandle(waitHandle). => m_waitHandle.
Basuke Suzuki
Comment 4 2018-06-14 11:56:39 PDT
Created attachment 342751 [details] PATCH Thanks Yusuke.
Basuke Suzuki
Comment 5 2018-06-14 15:06:00 PDT
Created attachment 342764 [details] FIX
Brent Fulgham
Comment 6 2018-06-15 12:09:22 PDT
Looks good!
WebKit Commit Bot
Comment 7 2018-06-15 12:36:07 PDT
Comment on attachment 342764 [details] FIX Clearing flags on attachment: 342764 Committed r232888: <https://trac.webkit.org/changeset/232888>
WebKit Commit Bot
Comment 8 2018-06-15 12:36:09 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-06-15 12:37:23 PDT
<rdar://problem/41168126>
Note You need to log in before you can comment on or make changes to this bug.