Bug 186565

Summary: Rebaseline WebCrypto API tests for High Sierra after r232641
Product: WebKit Reporter: Dawei Fenton (:realdawei) <realdawei>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews, jiewen_tan, lforschler, rniwa, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews101 for mac-sierra
none
Archive of layout-test-results from ews106 for mac-sierra-wk2
none
Archive of layout-test-results from ews113 for mac-sierra
none
Patch
none
Patch none

Description Dawei Fenton (:realdawei) 2018-06-12 09:23:42 PDT
Rebaseline the following tests after r232641

imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.html
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.worker.html
Comment 1 Dawei Fenton (:realdawei) 2018-06-12 09:29:54 PDT
Created attachment 342551 [details]
Patch
Comment 2 Ryan Haddad 2018-06-12 09:34:46 PDT
On what platforms is this test failing?
Comment 3 Dawei Fenton (:realdawei) 2018-06-12 09:36:29 PDT
(In reply to Ryan Haddad from comment #2)
> On what platforms is this test failing?

High Sierra
Comment 4 Build Bot 2018-06-12 10:19:00 PDT
Comment on attachment 342551 [details]
Patch

Attachment 342551 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/8148627

New failing tests:
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.html
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.worker.html
Comment 5 Build Bot 2018-06-12 10:19:02 PDT
Created attachment 342556 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 Jiewen Tan 2018-06-12 10:26:38 PDT
(In reply to David Fenton from comment #3)
> (In reply to Ryan Haddad from comment #2)
> > On what platforms is this test failing?
> 
> High Sierra

That is expected behavior as RSA-PSS is only supported for High Sierra/iOS11+.
Comment 7 Jiewen Tan 2018-06-12 10:28:06 PDT
(In reply to Jiewen Tan from comment #6)
> (In reply to David Fenton from comment #3)
> > (In reply to Ryan Haddad from comment #2)
> > > On what platforms is this test failing?
> > 
> > High Sierra
> 
> That is expected behavior as RSA-PSS is only supported for High
> Sierra/iOS11+.

And our EWS bots and bunch of others are not in High Sierra yet. So we need two different versions of expected files for RSA-PSS tests.
Comment 8 Build Bot 2018-06-12 11:40:04 PDT
Comment on attachment 342551 [details]
Patch

Attachment 342551 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/8149384

New failing tests:
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.html
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.worker.html
Comment 9 Build Bot 2018-06-12 11:40:05 PDT
Created attachment 342571 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 10 Build Bot 2018-06-12 12:03:08 PDT
Comment on attachment 342551 [details]
Patch

Attachment 342551 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/8149367

New failing tests:
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.html
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.worker.html
Comment 11 Build Bot 2018-06-12 12:03:09 PDT
Created attachment 342574 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 12 Dawei Fenton (:realdawei) 2018-06-12 13:11:30 PDT
Created attachment 342587 [details]
Patch
Comment 13 WebKit Commit Bot 2018-06-12 13:16:16 PDT
Comment on attachment 342587 [details]
Patch

Rejecting attachment 342587 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 342587, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/8151079
Comment 14 Dawei Fenton (:realdawei) 2018-06-12 13:22:14 PDT
Created attachment 342589 [details]
Patch
Comment 15 Ryan Haddad 2018-06-12 13:23:33 PDT
Comment on attachment 342589 [details]
Patch

Trying again.
Comment 16 WebKit Commit Bot 2018-06-12 13:51:01 PDT
Comment on attachment 342589 [details]
Patch

Clearing flags on attachment: 342589

Committed r232772: <https://trac.webkit.org/changeset/232772>
Comment 17 WebKit Commit Bot 2018-06-12 13:51:03 PDT
All reviewed patches have been landed.  Closing bug.
Comment 18 Radar WebKit Bug Importer 2018-06-12 13:52:32 PDT
<rdar://problem/41059917>
Comment 19 Ryan Haddad 2018-06-12 16:31:27 PDT
Follow up to add missing whitespace in https://trac.webkit.org/r232781.