Bug 186559

Summary: [GTK] Enable tests on the GTK EWS queue
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: REOPENED    
Severity: Normal CC: agomez, bugs-noreply, calvaris, cgarcia, commit-queue, ews-watchlist, glenn, lforschler, mcatanzaro, psaavedra, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186638
Bug Depends on: 186843    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews114 for mac-sierra
none
Archive of layout-test-results from ews206 for win-future none

Carlos Alberto Lopez Perez
Reported 2018-06-12 04:42:48 PDT
In order to make easier for contributors to get layout test results for the GTK port we will like to enable tests on the EWS queue.
Attachments
Patch (1.14 KB, patch)
2018-06-12 04:54 PDT, Carlos Alberto Lopez Perez
no flags
Archive of layout-test-results from ews114 for mac-sierra (3.02 MB, application/zip)
2018-06-12 06:57 PDT, EWS Watchlist
no flags
Archive of layout-test-results from ews206 for win-future (12.75 MB, application/zip)
2018-06-13 06:46 PDT, EWS Watchlist
no flags
Carlos Alberto Lopez Perez
Comment 1 2018-06-12 04:54:39 PDT
EWS Watchlist
Comment 2 2018-06-12 06:57:27 PDT
Comment on attachment 342525 [details] Patch Attachment 342525 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/8146053 New failing tests: js/dom/JSON-stringify.html
EWS Watchlist
Comment 3 2018-06-12 06:57:28 PDT
Created attachment 342531 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
Michael Catanzaro
Comment 4 2018-06-12 08:43:56 PDT
Comment on attachment 342525 [details] Patch OK, let's see how it goes.
Michael Catanzaro
Comment 5 2018-06-12 08:46:59 PDT
(In reply to Build Bot from comment #2) > Comment on attachment 342525 [details] > Patch > > Attachment 342525 [details] did not pass mac-debug-ews (mac): > Output: http://webkit-queues.webkit.org/results/8146053 > > New failing tests: > js/dom/JSON-stringify.html We'll need to do better than Mac at avoiding spam comments caused by flaky tests. :/ Anyway, we can always switch back if it's too much of a problem, so let's give it a try.
Carlos Alberto Lopez Perez
Comment 6 2018-06-12 08:48:58 PDT
(In reply to Michael Catanzaro from comment #4) > Comment on attachment 342525 [details] > Patch > > OK, let's see how it goes. Thanks for the review.. before landing I think we should do an extra effort to make the release GTK bot green
EWS Watchlist
Comment 7 2018-06-13 06:45:50 PDT
Comment on attachment 342525 [details] Patch Attachment 342525 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8162650 New failing tests: http/tests/security/local-video-source-from-remote.html http/tests/preload/onload_event.html
EWS Watchlist
Comment 8 2018-06-13 06:46:01 PDT
Created attachment 342650 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Carlos Alberto Lopez Perez
Comment 9 2018-06-14 10:56:19 PDT
Ok.. the GTK bot is now almost green (1 failure as of r232840) Let's land this now and see how it goes.
Carlos Alberto Lopez Perez
Comment 10 2018-06-14 10:57:28 PDT
Comment on attachment 342525 [details] Patch Clearing flags on attachment: 342525 Committed r232844: <https://trac.webkit.org/changeset/232844>
Carlos Alberto Lopez Perez
Comment 11 2018-06-14 10:57:32 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2018-06-14 10:59:24 PDT
WebKit Commit Bot
Comment 13 2018-06-20 06:50:14 PDT
Re-opened since this is blocked by bug 186843
Note You need to log in before you can comment on or make changes to this bug.