Bug 186541

Summary: Unpainted area while scrolling in Reader is white
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, dino, ews-watchlist, rniwa, simon.fraser, timothy, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews107 for mac-sierra-wk2
none
Patch
none
Archive of layout-test-results from ews206 for win-future
none
Patch none

Tim Horton
Reported 2018-06-11 14:53:26 PDT
Unpainted area while scrolling in Reader is white
Attachments
Patch (14.60 KB, patch)
2018-06-11 14:54 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (4.17 MB, application/zip)
2018-06-11 15:45 PDT, EWS Watchlist 		no flags
Details
Patch (16.60 KB, patch)
2018-06-12 00:01 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews206 for win-future (12.80 MB, application/zip)
2018-06-12 06:49 PDT, EWS Watchlist 		no flags
Details
Patch (19.56 KB, patch)
2018-06-12 12:24 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-06-11 14:54:26 PDT
Created attachment 342466 [details] Patch
Tim Horton
Comment 2 2018-06-11 14:54:37 PDT
<rdar://problem/40471363>
EWS Watchlist
Comment 3 2018-06-11 15:45:48 PDT
Comment on attachment 342466 [details] Patch Attachment 342466 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/8136386 New failing tests: tiled-drawing/fixed-layout-size-fixed-attachment-cover.html tiled-drawing/background-transparency-toggle.html tiled-drawing/fixed-layout-size-fixed-attachment-local.html
EWS Watchlist
Comment 4 2018-06-11 15:45:49 PDT
Created attachment 342473 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Tim Horton
Comment 5 2018-06-12 00:01:48 PDT
Created attachment 342518 [details] Patch
EWS Watchlist
Comment 6 2018-06-12 06:49:36 PDT
Comment on attachment 342518 [details] Patch Attachment 342518 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8145981 New failing tests: http/tests/security/contentSecurityPolicy/video-with-http-url-allowed-by-csp-media-src-star.html
EWS Watchlist
Comment 7 2018-06-12 06:49:47 PDT
Created attachment 342530 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Tim Horton
Comment 8 2018-06-12 12:24:38 PDT
Created attachment 342577 [details] Patch
WebKit Commit Bot
Comment 9 2018-06-19 16:06:16 PDT
Comment on attachment 342577 [details] Patch Clearing flags on attachment: 342577 Committed r232991: <https://trac.webkit.org/changeset/232991>
WebKit Commit Bot
Comment 10 2018-06-19 16:06:18 PDT
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 11 2018-07-31 18:27:44 PDT
Comment on attachment 342577 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342577&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:3148 > + if (!m_layerForOverhangAreas) > + return; Wait what? You're skipping the setRootLayerConfigurationNeedsUpdate() stuff below.
Tim Horton
Comment 12 2018-08-01 00:59:47 PDT
(In reply to Simon Fraser (smfr) from comment #11) > Comment on attachment 342577 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342577&action=review > > > Source/WebCore/rendering/RenderLayerCompositor.cpp:3148 > > + if (!m_layerForOverhangAreas) > > + return; > > Wait what? You're skipping the setRootLayerConfigurationNeedsUpdate() stuff > below. Err, yeah, that needs to only bail from the stuff inside that block
Note You need to log in before you can comment on or make changes to this bug.