Bug 186529 – Disable some vestibular trigger animations when prefers-reduced-motion is active.

• Component: WebKit Website
• Status: RESOLVED FIXED

[James Craig]

Disable some vestibular trigger animations when prefers-reduced-motion is active. For example, the blog post text floats upward right after a page load.

Regression since the time that this post went live.
https://webkit.org/blog/7551/responsive-design-for-motion/

[Jon Davis]

Created attachment 342758 [details]
Patch

[James Craig]

Comment on attachment 342758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342758&action=review

There are a bunch of whitespace-only diffs that should not be in this patch.

> Websites/webkit.org/wp-content/themes/webkit/style.css:1709
> +    article,

Do you really want this on all article elements? Maybe this style sheet already has limited inclusion? I'm okay with this if you're sure, but I'd expect you'd want to limit the motion (and subsequent reduction) to the primary article on blog posts only: Looks like the article has a post classname. e.g. selector could be `article.post { ... }`

[Jon Davis]

Created attachment 344977 [details]
Patch

[Jon Davis]

> Do you really want this on all article elements? Maybe this style sheet already has limited inclusion? I'm okay with this if you're sure, but I'd expect you'd want to limit the motion (and subsequent reduction) to the primary article on blog posts only: Looks like the article has a post classname. e.g. selector could be `article.post { ... }`

Yes, it should be on all article elements and the feature status page. This is a consistent page load animation across all content pages and posts on webkit.org. The motion should be replaced everywhere it is applied.

[EWS Watchlist]

Comment on attachment 344977 [details]
Patch

Attachment 344977 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8530553

New failing tests:
http/tests/security/canvas-remote-read-remote-video-redirect.html

[EWS Watchlist]

Created attachment 345003 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[WebKit Commit Bot]

Comment on attachment 344977 [details]
Patch

Clearing flags on attachment: 344977

Committed r234155: <https://trac.webkit.org/changeset/234155>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/42546539>