Summary: | [JSCOnly] Add a MIPS32el JSCOnly EWS | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||
Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, ap, bugs-noreply, calvaris, dbates, ews-watchlist, glenn, guijemont, lforschler, mcatanzaro, psaavedra, pvollan, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=172693 | ||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2018-06-11 08:14:56 PDT
Created attachment 342439 [details]
Patch
Comment on attachment 342439 [details] Patch Attachment 342439 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/8131235 New failing tests: media/video-buffering-allowed.html Created attachment 342450 [details]
Archive of layout-test-results from ews116 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 342439 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342439&action=review Yay! > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:38 > + LinuxJSCOnly: { name : "linux-jsc-only", readableName: "Linux JSCOnly", order: 92 } For this to work, don't you also need to edit WebKitBuildbot.js? We also need a logo under dashboard/Styles/Main.css. When I asked the compilers team the other day, there was not much feedback in the way of a good logo, so we might as well use https://webkit.org/blog-files/squirrelfish.png I guess. (In reply to Michael Catanzaro from comment #4) > Comment on attachment 342439 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342439&action=review > > Yay! > > > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:38 > > + LinuxJSCOnly: { name : "linux-jsc-only", readableName: "Linux JSCOnly", order: 92 } > > For this to work, don't you also need to edit WebKitBuildbot.js? > > We also need a logo under dashboard/Styles/Main.css. When I asked the > compilers team the other day, there was not much feedback in the way of a > good logo, so we might as well use > https://webkit.org/blog-files/squirrelfish.png I guess. Mmm... good point. It seems I confused BubbleQueueServer.js from the dashboard with the bubbles from bugzilla patch upload (the ones from the EWS). The ones from bugzilla seem to be handled in Tools/QueueStatusServer/handlers/statusbubble.py and Tools/QueueStatusServer/templates/statusbubble.html and as far as I can see that doesn't have any specific port/queue configuration. It just show the bubbles from the EWS queues as soon as they happen. I will remove from this patch the modifications to the dashboard, as it seems that such thing is not needed here. Committed r232748: <https://trac.webkit.org/changeset/232748> I updated webkit-queues server to pick up this changes. The queue is now visible at https://webkit-queues.webkit.org/queue-status/jsc-mips-ews However, there is no bot configured on this queue yet. So there are lot of pending patches for this queue. Can you please configure a bot on this queue soon? (In reply to Aakash Jain from comment #8) > I updated webkit-queues server to pick up this changes. The queue is now > visible at https://webkit-queues.webkit.org/queue-status/jsc-mips-ews > > However, there is no bot configured on this queue yet. So there are lot of > pending patches for this queue. Can you please configure a bot on this queue > soon? I just added a worker. I will be watching it over the next days to ensure it works as expected. Thanks for the help :) Committed r232789: <https://trac.webkit.org/changeset/232789> |