Bug 186496

Summary: [Web Animations] Make WPT test at interfaces/Animation/finish.html pass reliably
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186509
Attachments:
Description Flags
Patch dino: review+

Antoine Quint
Reported 2018-06-11 04:38:21 PDT
The WPT test at imported/w3c/web-platform-tests/web-animations/interfaces/Animation/finish.html is failing reliably, flaky or timing out.
Attachments
Patch (8.98 KB, patch)
2018-07-05 08:37 PDT, Antoine Quint 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-06-11 04:38:34 PDT
<rdar://problem/41000179>
Antoine Quint
Comment 2 2018-07-05 08:37:18 PDT
Created attachment 344330 [details] Patch
Dean Jackson
Comment 3 2018-07-06 11:40:35 PDT
Comment on attachment 344330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344330&action=review > Source/WebCore/animation/AnimationTimeline.h:84 > + const ListHashSet<WebAnimation*>& animationsWithoutTarget() const { return m_animationsWithoutTarget; } You never use this.
Antoine Quint
Comment 4 2018-07-06 11:44:05 PDT
Committed r233585: <https://trac.webkit.org/changeset/233585>
Antoine Quint
Comment 5 2018-07-06 11:44:38 PDT
(In reply to Dean Jackson from comment #3) > Comment on attachment 344330 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=344330&action=review > > > Source/WebCore/animation/AnimationTimeline.h:84 > > + const ListHashSet<WebAnimation*>& animationsWithoutTarget() const { return m_animationsWithoutTarget; } > > You never use this. We do in DocumentTimeline.cpp.
Note You need to log in before you can comment on or make changes to this bug.