Bug 186481

Summary: [GStreamer] flush video sample upon DRAIN query
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, eocanha, ews-watchlist, magomez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 186599    
Bug Blocks:    
Attachments:
Description Flags
Patch
calvaris: review+
Archive of layout-test-results from ews204 for win-future none

Philippe Normand
Reported 2018-06-11 03:19:47 PDT
.
Attachments
Patch (3.62 KB, patch)
2018-06-11 03:26 PDT, Philippe Normand 		calvaris: review+
DetailsFormatted DiffDiff
Archive of layout-test-results from ews204 for win-future (12.76 MB, application/zip)
2018-06-11 08:37 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2018-06-11 03:26:42 PDT
Created attachment 342415 [details] Patch
Enrique Ocaña
Comment 2 2018-06-11 04:47:47 PDT
I don't remember if this caused regressions with some layout tests which expected the last frame to be available. Better check it.
Philippe Normand
Comment 3 2018-06-11 06:52:34 PDT
I checked it. No regression detected!
EWS Watchlist
Comment 4 2018-06-11 08:37:19 PDT
Comment on attachment 342415 [details] Patch Attachment 342415 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8127912 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
EWS Watchlist
Comment 5 2018-06-11 08:37:33 PDT
Created attachment 342435 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Philippe Normand
Comment 6 2018-06-12 02:43:20 PDT
Committed r232747: <https://trac.webkit.org/changeset/232747>
Radar WebKit Bug Importer
Comment 7 2018-06-12 02:45:13 PDT
<rdar://problem/41038703>
Note You need to log in before you can comment on or make changes to this bug.