Summary: | [MotionMark] Add support for version numbers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Lee <jonlee> | ||||||
Component: | WebCore Misc. | Assignee: | Jon Lee <jonlee> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, ews-watchlist, rniwa, sabouhallawa, simon.fraser, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jon Lee
2018-06-10 23:12:52 PDT
Created attachment 342438 [details]
Patch
Comment on attachment 342438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342438&action=review > PerformanceTests/MotionMark/about.html:40 > + <div class="logo"><svg><use xlink:href="resources/runner/logo.svg#root" /></svg></div> I am not sure why we have to create an <svg> element which has a <use> element and this element references a target in an eternal <svg> especially there is only a single symbol in the logo.svg. Can't be just use <img width="525" height="130" src="logo.svg">? And of course get rid of the <symbol> tag from logo.svg. Comment on attachment 342438 [details] Patch Attachment 342438 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8145813 New failing tests: http/tests/preload/onload_event.html http/tests/security/video-poster-cross-origin-crash2.html Created attachment 342529 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 342438 [details] Patch Clearing flags on attachment: 342438 Committed r233147: <https://trac.webkit.org/changeset/233147> All reviewed patches have been landed. Closing bug. |