Summary: | [Win][MiniBrowser] Add WebKitBrowserWindow class for modern WebKit API | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||
Component: | Tools / Tests | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, don.olmstead, ews-watchlist, lforschler, pvollan, rniwa, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 184770 | ||||||
Attachments: |
|
Description
Fujii Hironori
2018-06-10 23:02:26 PDT
Created attachment 342411 [details]
Patch
Attachment 342411 [details] did not pass style-queue:
ERROR: Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:25: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:26: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Tools/MiniBrowser/win/MiniBrowserLibResource.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 3 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 342411 [details] Patch Clearing flags on attachment: 342411 Committed r232723: <https://trac.webkit.org/changeset/232723> All reviewed patches have been landed. Closing bug. |