Bug 186446

Summary: jumpTrueOrFalse only takes the fast path for boolean false
Product: WebKit Reporter: Tadeu Zagallo <tzagallo>
Component: JavaScriptCoreAssignee: Tadeu Zagallo <tzagallo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Tadeu Zagallo
Reported 2018-06-08 14:06:06 PDT
jumpTrueOrFalse did a mask check to take the fast path for boolean literals, but it would only work for false. Change it so that it takes the fast path for true, false and undefined.
Attachments
Patch (2.35 KB, patch)
2018-06-08 14:18 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.39 KB, patch)
2018-06-08 17:06 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-06-08 14:06:44 PDT
<rdar://problem/40949995>
Tadeu Zagallo
Comment 2 2018-06-08 14:18:51 PDT
Created attachment 342326 [details] Patch
Mark Lam
Comment 3 2018-06-08 15:02:24 PDT
Comment on attachment 342326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342326&action=review r=me with fixes. > Source/JavaScriptCore/ChangeLog:11 > + the fast path for true, false and undefined. and null too. This is only for 64-bit. For 32-bit, it was already taking the fast path for true or false, and still does for only those 2 values. Please add this to the ChangeLog comment so that we don't miscommunicate the scope of this change. > Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1824 > + btqnz t0, ~15, .slow nit: I prefer you use ~0xf instead so that we can think in terms of the bits being masked.
Tadeu Zagallo
Comment 4 2018-06-08 17:06:27 PDT
Created attachment 342346 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-06-08 17:57:29 PDT
Comment on attachment 342346 [details] Patch for landing Clearing flags on attachment: 342346 Committed r232658: <https://trac.webkit.org/changeset/232658>
WebKit Commit Bot
Comment 6 2018-06-08 17:57:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.