Bug 186445

Summary: [Win] Add IPC error case for broken pipe
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: PlatformAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: basuke, commit-queue, dbates, don.olmstead, ews-watchlist, Hironori.Fujii, pvollan, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204221
Attachments:
Description Flags
PATCH
rniwa: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews202 for win-future
none
FIX none

Basuke Suzuki
Reported 2018-06-08 14:00:50 PDT
Add error handling for ERROR_BROKEN_PIPE on IPC::Connection::readEventHandler.
Attachments
PATCH (1.18 KB, patch)
2018-06-08 14:04 PDT, Basuke Suzuki 		rniwa: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews202 for win-future (12.83 MB, application/zip)
2018-06-08 17:36 PDT, EWS Watchlist 		no flags
Details
FIX (1.18 KB, patch)
2018-06-14 16:24 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-06-08 14:04:09 PDT
Created attachment 342323 [details] PATCH
EWS Watchlist
Comment 2 2018-06-08 17:36:47 PDT
Comment on attachment 342323 [details] PATCH Attachment 342323 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8091811 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
EWS Watchlist
Comment 3 2018-06-08 17:36:58 PDT
Created attachment 342351 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Ryosuke Niwa
Comment 4 2018-06-11 13:37:23 PDT
Comment on attachment 342323 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=342323&action=review > Source/WebKit/ChangeLog:6 > + Add error handling for ERROR_BROKEN_PIPE on IPC::Connection::readEventHandler. Can we add some test?
Basuke Suzuki
Comment 5 2018-06-11 16:22:48 PDT
(In reply to Ryosuke Niwa from comment #4) > Comment on attachment 342323 [details] > PATCH > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342323&action=review > > > Source/WebKit/ChangeLog:6 > > + Add error handling for ERROR_BROKEN_PIPE on IPC::Connection::readEventHandler. > > Can we add some test? Ironically this patch is to run TestWebKit correctly. With this patch applied, it runs one step further to the goal so that means it works as expected. I wanna postpone this by opening a new bug for testing this. Does that make sense for you? >Ryosuke
Basuke Suzuki
Comment 6 2018-06-14 16:24:56 PDT
Created attachment 342774 [details] FIX I'll open a new bug to refactor IPC::Connection for Win soon. Thanks for r+ > Ryosuke
WebKit Commit Bot
Comment 7 2018-06-14 17:07:22 PDT
Comment on attachment 342774 [details] FIX Clearing flags on attachment: 342774 Committed r232860: <https://trac.webkit.org/changeset/232860>
WebKit Commit Bot
Comment 8 2018-06-14 17:07:24 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-06-14 17:09:12 PDT
<rdar://problem/41145073>
Note You need to log in before you can comment on or make changes to this bug.