Bug 186442

Summary:

[WebKit on watchOS] Upstream watchOS source additions to OpenSource

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebKit Misc.

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, bdakin, commit-queue, darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, thorton, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+, ews-watchlist: commit-queue-
Patch for landing	none
Archive of layout-test-results from ews200 for win-future	none
Form controls	thorton: review+
Patch for landing	none
Rename more references to extra zoom	none

Wenson Hsieh

Reported 2018-06-08 13:37:42 PDT

<rdar://problem/40879364>

Attachments
Patch (81.21 KB, patch) 2018-06-08 13:45 PDT, Wenson Hsieh	thorton: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Patch for landing (81.26 KB, patch) 2018-06-08 19:32 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews200 for win-future (12.89 MB, application/zip) 2018-06-08 20:11 PDT, EWS Watchlist	no flags	Details
Form controls (84.67 KB, patch) 2018-06-12 11:38 PDT, Wenson Hsieh	thorton: review+	Details Formatted Diff Diff
Patch for landing (84.69 KB, patch) 2018-06-12 12:28 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Rename more references to extra zoom (93.00 KB, patch) 2018-06-16 23:00 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2018-06-08 13:45:21 PDT

Created attachment 342317 [details] Patch

Wenson Hsieh

Comment 2 2018-06-08 19:32:24 PDT

Created attachment 342355 [details] Patch for landing

EWS Watchlist

Comment 3 2018-06-08 20:11:42 PDT

Comment on attachment 342317 [details] Patch Attachment 342317 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8094262 New failing tests: http/tests/preload/onload_event.html

EWS Watchlist

Comment 4 2018-06-08 20:11:54 PDT

Created attachment 342357 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

WebKit Commit Bot

Comment 5 2018-06-08 20:12:26 PDT

Comment on attachment 342355 [details] Patch for landing Clearing flags on attachment: 342355 Committed r232659: <https://trac.webkit.org/changeset/232659>

Wenson Hsieh

Comment 6 2018-06-12 11:38:11 PDT

Reopening to attach new patch.

Wenson Hsieh

Comment 7 2018-06-12 11:38:12 PDT

Created attachment 342570 [details] Form controls

Tim Horton

Comment 8 2018-06-12 12:04:26 PDT

Comment on attachment 342570 [details] Form controls View in context: https://bugs.webkit.org/attachment.cgi?id=342570&action=review > Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm:647 > + if (pickerView == _yearAndEraPicker) > + [_yearAndEraPicker setChangingValue:YES]; > + if (pickerView == _dayPicker) else if? > Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm:655 > + if (pickerView == _yearAndEraPicker) Ditto > Source/WebKit/UIProcess/ios/forms/WKNumberPadViewController.mm:145 > +- (void)_handleKeyPress:(WKNumberPadKey)key This is not my favorite thing in the world, but OK. > Source/WebKit/UIProcess/ios/forms/WKNumberPadViewController.mm:258 > + fadeOutAnimation.fromValue = @(1); Do you need the parens? > Source/WebKit/UIProcess/ios/forms/WKTimePickerViewController.mm:67 > + [_dateFormatter setLocale:[NSLocale localeWithLocaleIdentifier:@"en_US_POSIX"]]; en_US_POSIX, always?

Wenson Hsieh

Comment 9 2018-06-12 12:22:20 PDT

Comment on attachment 342570 [details] Form controls View in context: https://bugs.webkit.org/attachment.cgi?id=342570&action=review >> Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm:647 >> + if (pickerView == _dayPicker) > > else if? Sounds good. >> Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm:655 >> + if (pickerView == _yearAndEraPicker) > > Ditto Done! >> Source/WebKit/UIProcess/ios/forms/WKNumberPadViewController.mm:145 >> +- (void)_handleKeyPress:(WKNumberPadKey)key > > This is not my favorite thing in the world, but OK. I'm definitely taking suggestions! :/ >> Source/WebKit/UIProcess/ios/forms/WKNumberPadViewController.mm:258 >> + fadeOutAnimation.fromValue = @(1); > > Do you need the parens? Nope! Removed. >> Source/WebKit/UIProcess/ios/forms/WKTimePickerViewController.mm:67 >> + [_dateFormatter setLocale:[NSLocale localeWithLocaleIdentifier:@"en_US_POSIX"]]; > > en_US_POSIX, always? Yes. This is just used to transform hour and minute values into an input value (also see: -[WKDateTimePicker dateFormatterForPicker] on iOS).

Wenson Hsieh

Comment 10 2018-06-12 12:28:03 PDT

Created attachment 342581 [details] Patch for landing

WebKit Commit Bot

Comment 11 2018-06-12 13:07:29 PDT

Comment on attachment 342581 [details] Patch for landing Clearing flags on attachment: 342581 Committed r232770: <https://trac.webkit.org/changeset/232770>

Wenson Hsieh

Comment 12 2018-06-16 23:00:48 PDT

Created attachment 342908 [details] Rename more references to extra zoom

WebKit Commit Bot

Comment 13 2018-06-17 11:37:16 PDT

Comment on attachment 342908 [details] Rename more references to extra zoom Clearing flags on attachment: 342908 Committed r232916: <https://trac.webkit.org/changeset/232916>

Note You need to log in before you can comment on or make changes to this bug.