Bug 186425
| Summary: | REGRESSION (r232376): Layout Test inspector/console/webcore-logging.html is a flaky failure | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | inspector-bugzilla-changes, joepeck, keith_miller, realdawei, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=186162 | ||
Ryan Haddad
The following layout test is flaky on macOS Debug WK2
inspector/console/webcore-logging.html
Probable cause:
Unknown, this test started being flaky around https://trac.webkit.org/changeset/232376/webkit
Flakiness Dashboard:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fconsole%2Fwebcore-logging.html
--- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/inspector/console/webcore-logging-expected.txt
+++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/inspector/console/webcore-logging-actual.txt
@@ -33,6 +33,7 @@
-- Running test case: Console.Logging.LogAsJSONWithoutRepeat
PASS: Media logging disabled.
PASS: Verbose media logging has been enabled.
+ERROR: TypeError: undefined is not an object (evaluating 'listener.call')
PASS: Message logged as JSON.
PASS: ConsoleMessage repeatCount is 1.
PASS: Message logged as JSON.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryan Haddad
We need to find the regression point for this one.
Ryan Haddad
David determined that this regressed with https://trac.webkit.org/changeset/232376
Radar WebKit Bug Importer
<rdar://problem/40943111>
Dawei Fenton (:realdawei)
I've been able to reproduce the failure on a local build of r232376 using the following command:
run-webkit-tests inspector/console/webcore-logging.html --debug --iter 50 -f -g --no-retry
The test passes reliably on the previous build (r232375)
Ryan Haddad
Marked test as flaky in https://trac.webkit.org/r232777
Ryan Haddad
It doesn't look like this has happened recently on the bots and I can not reproduce with Dawei's steps above.
Ryan Haddad
Removed flaky expectation in https://trac.webkit.org/r238299
Joseph Pecoraro
Yay!