Summary: | [Win][MiniBrowser] Add a new BrowserWindow interface to abstract WK1 and WK2 BrowserWindow | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
Component: | Tools / Tests | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, bfulgham, darin, lforschler, pvollan, rniwa, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 184770 | ||||||||
Attachments: |
|
Description
Fujii Hironori
2018-06-07 20:09:37 PDT
Created attachment 342233 [details]
Patch
Comment on attachment 342233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342233&action=review > Tools/MiniBrowser/win/PrintWebUIDelegate.cpp:74 > + MiniBrowser* newBrowserWindow = static_cast<MiniBrowser*>(newWindow.browserWindow()); Can we use MiniBrowser& or auto& instead? Comment on attachment 342233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342233&action=review Thank you for the review. >> Tools/MiniBrowser/win/PrintWebUIDelegate.cpp:74 >> + MiniBrowser* newBrowserWindow = static_cast<MiniBrowser*>(newWindow.browserWindow()); > > Can we use MiniBrowser& or auto& instead? Agreed. Will fix with auto&. Created attachment 342241 [details]
Patch
Committed r232616: <https://trac.webkit.org/changeset/232616> (In reply to Fujii Hironori from comment #0) > I will rename MiniBrowser class to WK1BrowserWindow in a follow-up patch > (Bug 184770 Comment 12). I don’t think you should do that. The older WebKit programming model is no longer referred to as "WebKit 1" but rather "legacy WebKit" or "WebKitLegacy". (In reply to Darin Adler from comment #7) > (In reply to Fujii Hironori from comment #0) > > I will rename MiniBrowser class to WK1BrowserWindow in a follow-up patch > > (Bug 184770 Comment 12). > > I don’t think you should do that. The older WebKit programming model is no > longer referred to as "WebKit 1" but rather "legacy WebKit" or > "WebKitLegacy". Thank you for the feedback. We are discussing it in Bug 186427. |