| Summary: | REGRESSION(r224134) Client certificate challenges don't always appear | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bweinstein, commit-queue, dbates, ews-watchlist, ggaren, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2018-06-07 10:49:14 PDT
Created attachment 342189 [details]
Patch
Attachment 342189 [details] did not pass style-queue:
ERROR: Source/WebKit/ChangeLog:5: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebKit/ChangeLog:11: Line contains tab character. [whitespace/tab] [5]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 342189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342189&action=review > Source/WebKit/NetworkProcess/NetworkLoad.cpp:340 > + bool isTLSHandshake = m_challenge->protectionSpace().authenticationScheme() == ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested Is it worth pulling m_challenge->protectionSpace().authenticationScheme() into a local? Created attachment 342194 [details]
Patch
Comment on attachment 342194 [details] Patch Clearing flags on attachment: 342194 Committed r232594: <https://trac.webkit.org/changeset/232594> All reviewed patches have been landed. Closing bug. |