Bug 186402

Summary: REGRESSION(r224134) Client certificate challenges don't always appear
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, dbates, ews, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Alex Christensen 2018-06-07 10:49:14 PDT
REGRESSION(r224134) Client certificate challenges don't always appear
Comment 1 Alex Christensen 2018-06-07 10:50:21 PDT
Created attachment 342189 [details]
Patch
Comment 2 Build Bot 2018-06-07 10:52:10 PDT
Attachment 342189 [details] did not pass style-queue:


ERROR: Source/WebKit/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brian Weinstein 2018-06-07 11:18:28 PDT
Comment on attachment 342189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342189&action=review

> Source/WebKit/NetworkProcess/NetworkLoad.cpp:340
> +    bool isTLSHandshake = m_challenge->protectionSpace().authenticationScheme() == ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested

Is it worth pulling m_challenge->protectionSpace().authenticationScheme() into a local?
Comment 4 Alex Christensen 2018-06-07 11:40:01 PDT
Created attachment 342194 [details]
Patch
Comment 5 WebKit Commit Bot 2018-06-07 12:19:38 PDT
Comment on attachment 342194 [details]
Patch

Clearing flags on attachment: 342194

Committed r232594: <https://trac.webkit.org/changeset/232594>
Comment 6 WebKit Commit Bot 2018-06-07 12:19:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-06-07 12:20:21 PDT
<rdar://problem/40905729>