Bug 186394

Summary: [LFC] Merge height and vertical margin computation
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description zalan 2018-06-07 07:39:14 PDT
similar to width and horizontal margin computation
Comment 1 zalan 2018-06-07 07:51:00 PDT
Created attachment 342163 [details]
Comment 2 zalan 2018-06-07 07:53:33 PDT
Comment on attachment 342163 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=342163&action=review

> Source/WebCore/layout/FormattingContext.h:92
> +        struct HeightAndMargin {
> +            LayoutUnit height;
> +            Display::Box::VerticalEdges margin;
> +        };

I also tried
struct SizeAndMargin {
    std::optional<LayoutUnit> width;
    std::optional<LayoutUnit> height;
    std::optional<Display::Box::VerticalEdges> verticalMargin;
    std::optional<Display::Box::HorizontalEdges> horizontalMargin;
but it turned out to be too confusing with all the std::nullopts.
Comment 3 WebKit Commit Bot 2018-06-07 08:39:13 PDT
Comment on attachment 342163 [details]

Clearing flags on attachment: 342163

Committed r232581: <https://trac.webkit.org/changeset/232581>
Comment 4 WebKit Commit Bot 2018-06-07 08:39:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-06-07 08:40:23 PDT