Bug 186379

Summary: Run display links in the UI process when ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) is true.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
bfulgham: review+
Patch
none
Patch for landing none

Per Arne Vollan
Reported 2018-06-06 19:39:38 PDT
Replace __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 with ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING).
Attachments
Patch (5.04 KB, patch)
2018-06-06 19:43 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (5.20 KB, patch)
2018-06-06 19:51 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (5.43 KB, patch)
2018-06-06 20:11 PDT, Per Arne Vollan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch (5.44 KB, patch)
2018-06-06 20:18 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.46 KB, patch)
2018-06-08 10:36 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2018-06-06 19:43:22 PDT
Created attachment 342106 [details] Patch
Per Arne Vollan
Comment 2 2018-06-06 19:51:36 PDT
Created attachment 342108 [details] Patch
Per Arne Vollan
Comment 3 2018-06-06 20:11:33 PDT
Created attachment 342110 [details] Patch
Per Arne Vollan
Comment 4 2018-06-06 20:18:58 PDT
Created attachment 342112 [details] Patch
Radar WebKit Bug Importer
Comment 5 2018-06-08 10:00:14 PDT
<rdar://problem/40940236>
Brent Fulgham
Comment 6 2018-06-08 10:19:45 PDT
Comment on attachment 342110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342110&action=review Looks good. > Source/WebKit/UIProcess/mac/DisplayLink.cpp:29 > +#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) I wonder if we need the PLATFORM(MAC) here, since this is a Mac-specific file I think. > Source/WebKit/UIProcess/mac/DisplayLink.h:28 > +#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) Ditto. > Source/WebKit/WebProcess/WebPage/mac/DrawingAreaMac.cpp:41 > +#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) && PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) Again, I wonder if PLATFORM(MAC) is necessary in this Mac-specific file.
Per Arne Vollan
Comment 7 2018-06-08 10:34:19 PDT
(In reply to Brent Fulgham from comment #6) > Comment on attachment 342110 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342110&action=review > > Looks good. > > > Source/WebKit/UIProcess/mac/DisplayLink.cpp:29 > > +#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) > > I wonder if we need the PLATFORM(MAC) here, since this is a Mac-specific > file I think. > > > Source/WebKit/UIProcess/mac/DisplayLink.h:28 > > +#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) > > Ditto. > > > Source/WebKit/WebProcess/WebPage/mac/DrawingAreaMac.cpp:41 > > +#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) && PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) > > Again, I wonder if PLATFORM(MAC) is necessary in this Mac-specific file. Thanks for reviewing! I will update the patch before landing.
Per Arne Vollan
Comment 8 2018-06-08 10:36:10 PDT
Created attachment 342288 [details] Patch for landing
WebKit Commit Bot
Comment 9 2018-06-08 11:45:58 PDT
Comment on attachment 342288 [details] Patch for landing Clearing flags on attachment: 342288 Committed r232634: <https://trac.webkit.org/changeset/232634>
Note You need to log in before you can comment on or make changes to this bug.