| Summary: | Use the same overloaded addInputString in WKContentViewInteraction | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||||
| Component: | HTML Editing | Assignee: | Jiewen Tan <jiewen_tan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, ews-watchlist, jiewen_tan, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jiewen Tan
2018-06-06 18:11:28 PDT
Created attachment 342104 [details]
Patch
Comment on attachment 342104 [details] Patch Attachment 342104 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8046892 New failing tests: http/tests/preload/onload_event.html Created attachment 342127 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
The tree of win EWS bot is red. Should not blame this patch. Comment on attachment 342104 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342104&action=review r=me! Nice find. > Source/WebKit/ChangeLog:10 > + overloaded varaint consistently: [UIKeyboardImpl -addInputString:withFlags:withInputManagerHint:]. variant (the I/a are transposed) Created attachment 342198 [details]
Patch for landing
Comment on attachment 342198 [details] Patch for landing Clearing flags on attachment: 342198 Committed r232595: <https://trac.webkit.org/changeset/232595> All reviewed patches have been landed. Closing bug. |