Bug 186376

Summary: Use the same overloaded addInputString in WKContentViewInteraction
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: HTML EditingAssignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ews-watchlist, jiewen_tan, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews202 for win-future
none
Patch for landing none

Jiewen Tan
Reported 2018-06-06 18:11:28 PDT
It turns out that different addInputString overloads behave differently. We should use the same overload version consistently: [UIKeyboardImpl -addInputString:withFlags:withInputManagerHint:].
Attachments
Patch (1.93 KB, patch)
2018-06-06 18:32 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews202 for win-future (12.82 MB, application/zip)
2018-06-06 23:40 PDT, EWS Watchlist 		no flags
Details
Patch for landing (1.93 KB, patch)
2018-06-07 12:09 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2018-06-06 18:11:50 PDT
<rdar://problem/18498360>
Jiewen Tan
Comment 2 2018-06-06 18:32:25 PDT
Created attachment 342104 [details] Patch
EWS Watchlist
Comment 3 2018-06-06 23:39:53 PDT
Comment on attachment 342104 [details] Patch Attachment 342104 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8046892 New failing tests: http/tests/preload/onload_event.html
EWS Watchlist
Comment 4 2018-06-06 23:40:04 PDT
Created attachment 342127 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Jiewen Tan
Comment 5 2018-06-07 10:25:30 PDT
The tree of win EWS bot is red. Should not blame this patch.
Brent Fulgham
Comment 6 2018-06-07 10:51:56 PDT
Comment on attachment 342104 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342104&action=review r=me! Nice find. > Source/WebKit/ChangeLog:10 > + overloaded varaint consistently: [UIKeyboardImpl -addInputString:withFlags:withInputManagerHint:]. variant (the I/a are transposed)
Jiewen Tan
Comment 7 2018-06-07 12:09:00 PDT
Created attachment 342198 [details] Patch for landing
WebKit Commit Bot
Comment 8 2018-06-07 12:48:53 PDT
Comment on attachment 342198 [details] Patch for landing Clearing flags on attachment: 342198 Committed r232595: <https://trac.webkit.org/changeset/232595>
WebKit Commit Bot
Comment 9 2018-06-07 12:48:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.