Bug 186374

Summary: [CoordGraphics] Fix compilation errors around USE(COORDINATED_GRAPHICS)
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 186364    
Attachments:
Description Flags
Patch none

Description Don Olmstead 2018-06-06 17:54:38 PDT
There are a few cases around PLATFORM, USE and ENABLE that prevent compilation of a platform wanting to enable CoordinatedGraphics.

Encountered these while seeing what needed to be done to get WinCairo using CoordinatedGraphics.
Comment 1 Don Olmstead 2018-06-06 17:56:32 PDT
Created attachment 342100 [details]
Patch
Comment 2 EWS Watchlist 2018-06-06 17:59:25 PDT
Attachment 342100 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:273:  Line contains only semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2018-06-07 11:36:53 PDT
Comment on attachment 342100 [details]
Patch

Clearing flags on attachment: 342100

Committed r232590: <https://trac.webkit.org/changeset/232590>
Comment 4 WebKit Commit Bot 2018-06-07 11:36:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-06-07 11:37:19 PDT
<rdar://problem/40903814>