Bug 186351

Summary: ArityFixup should adjust SP first on 32-bit platforms too
Product: WebKit Reporter: Guillaume Emont <guijemont>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, guijemont, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Guillaume Emont 2018-06-06 09:19:35 PDT 
We see the same problem as in bug 167239 on linux x86 (32-bits). The same solution (adjusting sp first) seems to fix it.
Comment 1 Guillaume Emont 2018-06-06 09:27:02 PDT 
Created attachment 342052 [details]
Patch

The patch. Seems to fix the issue in my tests. I also added the untag/tag calls though I'm not entirely sure how they work or if we want them on 32-bit too.
Comment 2 Yusuke Suzuki 2018-06-06 19:16:53 PDT 
Comment on attachment 342052 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2018-06-06 19:43:36 PDT 
Comment on attachment 342052 [details]
Patch

Clearing flags on attachment: 342052

Committed r232568: <https://trac.webkit.org/changeset/232568>
Comment 4 WebKit Commit Bot 2018-06-06 19:43:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-06-06 19:44:19 PDT 
<rdar://problem/40878480>