Bug 186351 - ArityFixup should adjust SP first on 32-bit platforms too
Summary: ArityFixup should adjust SP first on 32-bit platforms too
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2018-06-06 09:19 PDT by Guillaume Emont
Modified: 2018-06-06 19:44 PDT (History)
9 users (show)

See Also:

Patch (3.32 KB, patch)
2018-06-06 09:27 PDT, Guillaume Emont
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guillaume Emont 2018-06-06 09:19:35 PDT
We see the same problem as in bug 167239 on linux x86 (32-bits). The same solution (adjusting sp first) seems to fix it.
Comment 1 Guillaume Emont 2018-06-06 09:27:02 PDT
Created attachment 342052 [details]

The patch. Seems to fix the issue in my tests. I also added the untag/tag calls though I'm not entirely sure how they work or if we want them on 32-bit too.
Comment 2 Yusuke Suzuki 2018-06-06 19:16:53 PDT
Comment on attachment 342052 [details]

Comment 3 WebKit Commit Bot 2018-06-06 19:43:36 PDT
Comment on attachment 342052 [details]

Clearing flags on attachment: 342052

Committed r232568: <https://trac.webkit.org/changeset/232568>
Comment 4 WebKit Commit Bot 2018-06-06 19:43:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-06-06 19:44:19 PDT