Bug 186328

Summary: Set the AVAssetResourceLoaderRequest's contentType to AVStreamingKeyDeliveryContentKeyType in the case of a FPS key request.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jer Noble
Reported 2018-06-05 16:44:18 PDT
Set the AVAssetResourceLoaderRequest's contentType to AVStreamingKeyDeliveryContentKeyType in the case of a FPS key request.
Attachments
Patch (3.01 KB, patch)
2018-06-05 16:47 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.00 KB, patch)
2018-06-05 21:23 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-06-05 16:44:53 PDT
<rdar://problem/40829228>
Jer Noble
Comment 2 2018-06-05 16:47:11 PDT
Created attachment 342006 [details] Patch
Eric Carlson
Comment 3 2018-06-05 20:50:20 PDT
Comment on attachment 342006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342006&action=review r=me once the bots are happy. > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2492 > + infoRequest.contentType = AVStreamingKeyDeliveryContentKeyType; Is this string available in every version is the OS we support?
Jer Noble
Comment 4 2018-06-05 20:55:39 PDT
Comment on attachment 342006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342006&action=review >> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2492 >> + infoRequest.contentType = AVStreamingKeyDeliveryContentKeyType; > > Is this string available in every version is the OS we support? This is wrapped in a ENABLE(ENCRYPTED_MEDIA) check, which is only enabled on platforms which will deliver this string.
Jer Noble
Comment 5 2018-06-05 21:23:10 PDT
Created attachment 342029 [details] Patch for landing
WebKit Commit Bot
Comment 6 2018-06-06 09:10:53 PDT
Comment on attachment 342029 [details] Patch for landing Clearing flags on attachment: 342029 Committed r232542: <https://trac.webkit.org/changeset/232542>
WebKit Commit Bot
Comment 7 2018-06-06 09:10:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.