Bug 186324

Summary: [Cocoa] Retire DispatchPtr, and add more move semantics and simpler #ifs to other smart pointers
Product: WebKit Reporter: Darin Adler <darin>
Component: Web Template FrameworkAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, dbates, mitz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Darin Adler
Reported 2018-06-05 14:36:17 PDT
[Cocoa] Retire DispatchPtr, and add more move semantics and simpler #ifs to other smart pointers
Attachments
Patch (23.25 KB, patch)
2018-06-05 14:42 PDT, Darin Adler 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2018-06-05 14:42:59 PDT
Created attachment 341996 [details] Patch
Anders Carlsson
Comment 2 2018-06-05 14:45:20 PDT
Comment on attachment 341996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341996&action=review > Source/WTF/wtf/RetainPtr.h:118 > -#if defined (__OBJC__) && __has_feature(objc_arc) > +#if __has_feature(objc_arc) I think you might have to keep this in RetainPtr, unless __has_feature is defined away on Windows.
Darin Adler
Comment 3 2018-06-05 14:55:50 PDT
Comment on attachment 341996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341996&action=review >> Source/WTF/wtf/RetainPtr.h:118 >> +#if __has_feature(objc_arc) > > I think you might have to keep this in RetainPtr, unless __has_feature is defined away on Windows. All right. I will. Or I could use COMPILER_HAS_CLANG_FEATURE. But I will just leave this unmodified. Even though the space after "defined" drives me a little nuts.
Darin Adler
Comment 4 2018-06-05 17:18:33 PDT
Committed r232528: <https://trac.webkit.org/changeset/232528>
Radar WebKit Bug Importer
Comment 5 2018-06-05 17:19:24 PDT
<rdar://problem/40830436>
Note You need to log in before you can comment on or make changes to this bug.