Bug 186306

Summary: Rename color-filter to -apple-color-filter and do not expose it to Web content
Product: WebKit Reporter: Antoine Quint <graouts>
Component: CSSAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch simon.fraser: review+, simon.fraser: commit-queue-

Antoine Quint
Reported 2018-06-05 06:06:27 PDT
The CSS color-filter property was created to support some macOS Mojave-specific features and should not be exposed to the Web.
Attachments
Patch (107.13 KB, patch)
2018-06-05 08:21 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (111.09 KB, patch)
2018-06-05 08:40 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (106.70 KB, patch)
2018-06-06 01:27 PDT, Antoine Quint 		simon.fraser: review+
simon.fraser: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2018-06-05 06:06:42 PDT
<rdar://problem/39874167>
Antoine Quint
Comment 2 2018-06-05 08:21:26 PDT
Created attachment 341967 [details] Patch
Antoine Quint
Comment 3 2018-06-05 08:23:32 PDT
For the reviewer: somehow the JS accessors and setters on CSSStyleDeclaration don't seem to work for .appleColorFilter and some tests fail. What am I missing to ensure that these work? Or is that not a big deal?
Antoine Quint
Comment 4 2018-06-05 08:26:43 PDT
Using setProperty("-apple-color-filter", …) and getPropertyValue("-apple-color-filter") instead of the appleColorFilter accessor and setter works as expected.
Antoine Quint
Comment 5 2018-06-05 08:40:24 PDT
Created attachment 341968 [details] Patch
Antoine Quint
Comment 6 2018-06-05 08:40:56 PDT
I update the couple of problematic tests and the css3/color-filters subdirectory should now pass just fine.
Antoine Quint
Comment 7 2018-06-06 01:27:30 PDT
Created attachment 342039 [details] Patch
Simon Fraser (smfr)
Comment 8 2018-06-06 12:02:54 PDT
Comment on attachment 342039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342039&action=review > Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:570 > +WK_EXPORT void WKPreferencesSetColorFilterEnabled(WKPreferencesRef preferencesRef, bool flag); > +WK_EXPORT bool WKPreferencesGetColorFilterEnabled(WKPreferencesRef preferencesRef); No need to have the preferencesRef name here. > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:73 > +@property (nonatomic, setter=_setColorFilterEnabled:) BOOL _colorFilterEnabled WK_API_AVAILABLE(macosx(10.14)); This should be a TBA version, and also available in iOS TBA.
Antoine Quint
Comment 9 2018-06-06 15:27:28 PDT
Committed r232559: <https://trac.webkit.org/changeset/232559>
Note You need to log in before you can comment on or make changes to this bug.