Summary: | Rename color-filter to -apple-color-filter and do not expose it to Web content | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||
Component: | CSS | Assignee: | Antoine Quint <graouts> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | simon.fraser, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Safari Technology Preview | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Antoine Quint
2018-06-05 06:06:27 PDT
Created attachment 341967 [details]
Patch
For the reviewer: somehow the JS accessors and setters on CSSStyleDeclaration don't seem to work for .appleColorFilter and some tests fail. What am I missing to ensure that these work? Or is that not a big deal? Using setProperty("-apple-color-filter", …) and getPropertyValue("-apple-color-filter") instead of the appleColorFilter accessor and setter works as expected. Created attachment 341968 [details]
Patch
I update the couple of problematic tests and the css3/color-filters subdirectory should now pass just fine. Created attachment 342039 [details]
Patch
Comment on attachment 342039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342039&action=review > Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:570 > +WK_EXPORT void WKPreferencesSetColorFilterEnabled(WKPreferencesRef preferencesRef, bool flag); > +WK_EXPORT bool WKPreferencesGetColorFilterEnabled(WKPreferencesRef preferencesRef); No need to have the preferencesRef name here. > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:73 > +@property (nonatomic, setter=_setColorFilterEnabled:) BOOL _colorFilterEnabled WK_API_AVAILABLE(macosx(10.14)); This should be a TBA version, and also available in iOS TBA. Committed r232559: <https://trac.webkit.org/changeset/232559> |