The CSS color-filter property was created to support some macOS Mojave-specific features and should not be exposed to the Web.
Created attachment 341967 [details]
For the reviewer: somehow the JS accessors and setters on CSSStyleDeclaration don't seem to work for .appleColorFilter and some tests fail. What am I missing to ensure that these work? Or is that not a big deal?
Using setProperty("-apple-color-filter", …) and getPropertyValue("-apple-color-filter") instead of the appleColorFilter accessor and setter works as expected.
Created attachment 341968 [details]
I update the couple of problematic tests and the css3/color-filters subdirectory should now pass just fine.
Created attachment 342039 [details]
Comment on attachment 342039 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=342039&action=review
> +WK_EXPORT void WKPreferencesSetColorFilterEnabled(WKPreferencesRef preferencesRef, bool flag);
> +WK_EXPORT bool WKPreferencesGetColorFilterEnabled(WKPreferencesRef preferencesRef);
No need to have the preferencesRef name here.
> +@property (nonatomic, setter=_setColorFilterEnabled:) BOOL _colorFilterEnabled WK_API_AVAILABLE(macosx(10.14));
This should be a TBA version, and also available in iOS TBA.
Committed r232559: <https://trac.webkit.org/changeset/232559>