Bug 186299

Summary: Add the basic support for writing components in node.js
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dewei_zhu, ews-watchlist, koivisto, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 184340    
Attachments:
Description Flags
Adds MarkupComponentBase and MarkupPage
ews-watchlist: commit-queue-
Archive of layout-test-results from ews205 for win-future
none
Fixed a bug koivisto: review+

Ryosuke Niwa
Reported 2018-06-04 22:22:02 PDT
For the purpose of rewriting change detection scripts & email notifications using v3 code, it would be extremely useful to be able to write & run components in node.js.
Attachments
Adds MarkupComponentBase and MarkupPage (113.41 KB, patch)
2018-06-05 21:27 PDT, Ryosuke Niwa 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews205 for win-future (12.74 MB, application/zip)
2018-06-06 02:35 PDT, EWS Watchlist 		no flags
Details
Fixed a bug (114.66 KB, patch)
2018-06-06 16:32 PDT, Ryosuke Niwa 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-06-05 21:27:35 PDT
Created attachment 342030 [details] Adds MarkupComponentBase and MarkupPage
EWS Watchlist
Comment 2 2018-06-06 02:35:25 PDT
Comment on attachment 342030 [details] Adds MarkupComponentBase and MarkupPage Attachment 342030 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8027573 New failing tests: http/tests/security/canvas-remote-read-remote-video-redirect.html
EWS Watchlist
Comment 3 2018-06-06 02:35:36 PDT
Created attachment 342040 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
dewei_zhu
Comment 4 2018-06-06 16:04:04 PDT
Comment on attachment 342030 [details] Adds MarkupComponentBase and MarkupPage View in context: https://bugs.webkit.org/attachment.cgi?id=342030&action=review > Websites/perf.webkit.org/tools/js/markup-component.js:361 > +class MarkupComponentBase extends CommonComponentBase { Do we need to import CommonComponentBase in this class for node environment?
Ryosuke Niwa
Comment 5 2018-06-06 16:21:52 PDT
(In reply to dewei_zhu from comment #4) > Comment on attachment 342030 [details] > Adds MarkupComponentBase and MarkupPage > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342030&action=review > > > Websites/perf.webkit.org/tools/js/markup-component.js:361 > > +class MarkupComponentBase extends CommonComponentBase { > > Do we need to import CommonComponentBase in this class for node environment? Yes, do that where this is used.
Ryosuke Niwa
Comment 6 2018-06-06 16:32:22 PDT
Created attachment 342093 [details] Fixed a bug
Ryosuke Niwa
Comment 7 2018-06-07 11:25:37 PDT
Committed r232588: <https://trac.webkit.org/changeset/232588>
Radar WebKit Bug Importer
Comment 8 2018-06-07 11:27:09 PDT
<rdar://problem/40903267>
Note You need to log in before you can comment on or make changes to this bug.