Bug 186288

Summary: Selection color is dark when using Safari in dark mode
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Layout and RenderingAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, bfulgham, commit-queue, fujii.hironori, megan_gardner, simon.fraser, thorton, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186296
Attachments:
Description Flags
Patch
none
Patch none

Timothy Hatcher
Reported 2018-06-04 15:36:21 PDT
The selection color should be light, since Safari does not use system appearance for web content. <rdar://problem/38438625>
Attachments
Patch (33.52 KB, patch)
2018-06-04 15:46 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (33.66 KB, patch)
2018-06-04 15:54 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2018-06-04 15:46:37 PDT
Created attachment 341926 [details] Patch
Timothy Hatcher
Comment 2 2018-06-04 15:54:51 PDT
Created attachment 341931 [details] Patch
Megan Gardner
Comment 3 2018-06-04 16:22:39 PDT
Comment on attachment 341931 [details] Patch r=me
WebKit Commit Bot
Comment 4 2018-06-04 16:38:31 PDT
Comment on attachment 341931 [details] Patch Clearing flags on attachment: 341931 Committed r232486: <https://trac.webkit.org/changeset/232486>
WebKit Commit Bot
Comment 5 2018-06-04 16:38:33 PDT
All reviewed patches have been landed. Closing bug.
Fujii Hironori
Comment 6 2018-06-04 19:04:04 PDT
Windows ports can't compile. Filed Bug 186296
Note You need to log in before you can comment on or make changes to this bug.