Bug 186288 - Selection color is dark when using Safari in dark mode
Summary: Selection color is dark when using Safari in dark mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-04 15:36 PDT by Timothy Hatcher
Modified: 2018-06-04 19:04 PDT (History)
8 users (show)

See Also:

Attachments
Patch (33.52 KB, patch)
2018-06-04 15:46 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (33.66 KB, patch)
2018-06-04 15:54 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2018-06-04 15:36:21 PDT 
The selection color should be light, since Safari does not use system appearance for web content.

<rdar://problem/38438625>
Comment 1 Timothy Hatcher 2018-06-04 15:46:37 PDT 
Created attachment 341926 [details]
Patch
Comment 2 Timothy Hatcher 2018-06-04 15:54:51 PDT 
Created attachment 341931 [details]
Patch
Comment 3 Megan Gardner 2018-06-04 16:22:39 PDT 
Comment on attachment 341931 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-06-04 16:38:31 PDT 
Comment on attachment 341931 [details]
Patch

Clearing flags on attachment: 341931

Committed r232486: <https://trac.webkit.org/changeset/232486>
Comment 5 WebKit Commit Bot 2018-06-04 16:38:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Fujii Hironori 2018-06-04 19:04:04 PDT 
Windows ports can't compile.
Filed Bug 186296