Summary: | Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy" | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, ggaren, japhet, joepeck, kangil.han, kondapallykalyan, rniwa, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Chris Dumez
2018-06-04 15:22:01 PDT
Created attachment 341927 [details]
Patch
Created attachment 341932 [details]
Patch
Comment on attachment 341932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341932&action=review > Source/WebCore/ChangeLog:9 > + CrossOriginWindowPolicy Not needed > Source/WebCore/page/AbstractDOMWindow.cpp:41 > AbstractDOMWindow::AbstractDOMWindow(GlobalWindowIdentifier&& identifier) GlobalWindowIdentifier&& does not seem to bring any advantage over const GlobalWindowIdentifier& or is it special in some way? > Source/WebCore/page/AbstractDOMWindow.h:57 > + CrossOriginWindowPolicy crossOriginWindowPolicy() { return m_crossOriginWindowPolicy; } const > Source/WebCore/page/AbstractDOMWindow.h:69 > + CrossOriginWindowPolicy m_crossOriginWindowPolicy; Can we set the default value here instead of the constructor? > Source/WebKitLegacy/mac/WebView/WebPreferences.mm:637 > + [NSNumber numberWithBool:NO], WebKitCrossOriginWindowPolicySupportEnabledPreferenceKey, Should we set it to true by default for WK1 as well? > Source/WebKitLegacy/win/WebPreferences.cpp:252 > + CFDictionaryAddValue(defaults, CFSTR(WebKitCrossOriginWindowPolicySupportEnabledPreferenceKey), kCFBooleanFalse); Is there anything preventing us from aligning windows with other ports? > Tools/DumpRenderTree/mac/DumpRenderTree.mm:865 > + [preferences setCrossOriginWindowPolicySupportEnabled:YES]; If we set it to true in Mac/win, we could remove these lines Created attachment 341951 [details]
Patch
Comment on attachment 341951 [details] Patch Clearing flags on attachment: 341951 Committed r232499: <https://trac.webkit.org/changeset/232499> All reviewed patches have been landed. Closing bug. |