Bug 186285

Summary: Add iOS 12 and watchOS 5 to webkitpy
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, ews-watchlist, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
jbedard: commit-queue-
Patch none

Jonathan Bedard
Reported 2018-06-04 14:32:27 PDT
Adds support for 2018 embedded Apple operating systems, namely iOS 12 and watchOS 5.
Attachments
Patch (10.91 KB, patch)
2018-06-04 15:01 PDT, Jonathan Bedard 		jbedard: commit-queue-
DetailsFormatted DiffDiff
Patch (14.81 KB, patch)
2018-06-07 09:28 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2018-06-04 15:01:44 PDT
Created attachment 341921 [details] Patch
Alexey Proskuryakov
Comment 2 2018-06-04 15:43:14 PDT
This is one huge merge conflict with https://bugs.webkit.org/attachment.cgi?id=341917&action=review
Jonathan Bedard
Comment 3 2018-06-04 15:49:15 PDT
(In reply to Alexey Proskuryakov from comment #2) > This is one huge merge conflict with > https://bugs.webkit.org/attachment.cgi?id=341917&action=review Yes. I assumed that https://bugs.webkit.org/attachment.cgi?id=341917&action=review would land first.
Alexey Proskuryakov
Comment 4 2018-06-04 15:54:17 PDT
Comment on attachment 341921 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341921&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py:40 > + assert(target_platform in ("mac-yosemite", "mac-elcapitan", "mac-sierra", "mac-highsierra", "win", "ios-11", "ios-simulator-11", "ios-12", "ios-simulator-12")) Do we also need to add empty directories for test results? I believe that run-webkit-tests wants directories to exist. > Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:43 > + (["LayoutTests/platform/ios-simulator-wk1/foo"], ["ios-11", "ios-simulator-11", "ios-12", "ios-simulator-12"]), We don't have any tests that verify what happens when checking in to version specific iOS directories. We should, especially if that works properly.
Jonathan Bedard
Comment 5 2018-06-07 09:28:19 PDT
Created attachment 342177 [details] Patch
Jonathan Bedard
Comment 6 2018-06-07 09:31:24 PDT
attachment 342177 [details] adds tests for versions specific test expectations. To address Alexey's comment about run-webkit-tests: No, run-webkit-tests does not require that test expectation directories exist.
WebKit Commit Bot
Comment 7 2018-06-15 10:17:00 PDT
Comment on attachment 342177 [details] Patch Clearing flags on attachment: 342177 Committed r232877: <https://trac.webkit.org/changeset/232877>
WebKit Commit Bot
Comment 8 2018-06-15 10:17:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-06-15 10:17:16 PDT
<rdar://problem/41163215>
Note You need to log in before you can comment on or make changes to this bug.