Bug 186282

Summary: Add Mojave support to WebKit tools
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, ews-watchlist, glenn, lforschler, mitz, realdawei, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch dbates: review+, ap: commit-queue-

Alexey Proskuryakov
Reported 2018-06-04 13:50:28 PDT
Add macOS Mojave support to WebKit tools.
Attachments
proposed patch (176.99 KB, patch)
2018-06-04 13:55 PDT, Alexey Proskuryakov 		dbates: review+
ap: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2018-06-04 13:55:51 PDT
Created attachment 341917 [details] proposed patch
Daniel Bates
Comment 2 2018-06-04 15:45:52 PDT
Comment on attachment 341917 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=341917&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:192 > + content: -webkit-image-set(url(../Images/Mojave@2x.png) 2x, url(../Images/Mojave.png) 1x); Mojave@2x.png is not included in this patch. Is this intentional?
Alexey Proskuryakov
Comment 3 2018-06-04 15:47:31 PDT
Not intentional, but expected - the "@" character is special in svn, so many tools fail when it's present. Thank you for the review!
Alexey Proskuryakov
Comment 4 2018-06-04 15:49:21 PDT
Committed http://trac.webkit.org/r232483.
Radar WebKit Bug Importer
Comment 5 2018-06-04 15:50:21 PDT
<rdar://problem/40784451>
Note You need to log in before you can comment on or make changes to this bug.