Bug 186239

Summary:

Update Strong Password appearance

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Layout and Rendering

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, ews-watchlist, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Mac

OS:

macOS 10.13

Attachments:

Description	Flags
For EWS	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch	bfulgham: review+

Daniel Bates

Reported 2018-06-02 15:31:17 PDT

Update Strong Password appearance.

Attachments
For EWS (12.74 KB, patch) 2018-06-02 15:34 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.33 MB, application/zip) 2018-06-02 17:19 PDT, EWS Watchlist	no flags	Details
Patch (15.68 KB, patch) 2018-06-02 17:48 PDT, Daniel Bates	bfulgham: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2018-06-02 15:31:38 PDT

<rdar://problem/38183795>

Daniel Bates

Comment 2 2018-06-02 15:34:56 PDT

Created attachment 341853 [details] For EWS

EWS Watchlist

Comment 3 2018-06-02 17:19:03 PDT Comment hidden (obsolete)

Comment on attachment 341853 [details] For EWS Attachment 341853 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7949901 New failing tests: fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html fast/forms/auto-fill-button/input-strong-password-auto-fill-button.html

EWS Watchlist

Comment 4 2018-06-02 17:19:05 PDT Comment hidden (obsolete)

Created attachment 341856 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Daniel Bates

Comment 5 2018-06-02 17:48:28 PDT

Created attachment 341857 [details] Patch

Daniel Bates

Comment 6 2018-06-02 17:50:46 PDT

Comment on attachment 341857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341857&action=review > Source/WebCore/ChangeLog:15 > + only apply inner text element styles when the field is not disabled or read-only and has *only apply strong password-specific inner text element styles (will fix before landing)

Brent Fulgham

Comment 7 2018-06-03 11:03:40 PDT

Comment on attachment 341857 [details] Patch r=me

Daniel Bates

Comment 8 2018-06-04 14:29:48 PDT

Committed r232480: <https://trac.webkit.org/changeset/232480>

Note You need to log in before you can comment on or make changes to this bug.