Bug 186205 – REGRESSION (r229872): Unable to log into twitter.com in private sessions

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

Unable to log into twitter.com in private sessions since http://trac.webkit.org/r230567.

[Chris Dumez]

<rdar://problem/40670799>

[Chris Dumez]

Created attachment 341783 [details]
Patch

[youenn fablet]

Comment on attachment 341783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341783&action=review

> Source/WebCore/workers/service/server/SWServer.cpp:-75
> -    RELEASE_ASSERT(m_jobQueues.isEmpty());

Shouldn't we also remove the first assert?

> Source/WebKit/UIProcess/WebProcessPool.cpp:734
> +    }

You might be able to use sendToNetworkingProcess/sendToStorageProcess to improve the readability.
Something like:
if (privateBrowsingEnabled) {
   ...
   return;
}

sendToNetworkingProcess(Messages::NetworkProcess::DestroySession(PAL::SessionID::legacyPrivateSessionID()), 0);
sendToStorageProcess(Messages::StorageProcess::DestroySession(PAL::SessionID::legacyPrivateSessionID()), 0);
sendToAllProcesses(Messages::WebProcess::DestroySession(PAL::SessionID::legacyPrivateSessionID()));

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1482
> +            weakThis->removePrevalentDomains(domainsToRemove);

Lambdas do not seem to make things better here.
How about passing the weakThis once to WebResourceLoadStatisticsStore, which could then call the removePrevalentDomains/removeAllStorageAccessHandler/grantStorageAccessHandler/... methods directly.

[Chris Dumez]

Comment on attachment 341783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341783&action=review

>> Source/WebCore/workers/service/server/SWServer.cpp:-75
>> -    RELEASE_ASSERT(m_jobQueues.isEmpty());
> 
> Shouldn't we also remove the first assert?

I am not sure. It seems to work. When a session is destroyed, all its web processes should have been destroyed so we should no longer have connections to them.

>> Source/WebKit/UIProcess/WebProcessPool.cpp:734
>> +    }
> 
> You might be able to use sendToNetworkingProcess/sendToStorageProcess to improve the readability.
> Something like:
> if (privateBrowsingEnabled) {
>    ...
>    return;
> }
> 
> sendToNetworkingProcess(Messages::NetworkProcess::DestroySession(PAL::SessionID::legacyPrivateSessionID()), 0);
> sendToStorageProcess(Messages::StorageProcess::DestroySession(PAL::SessionID::legacyPrivateSessionID()), 0);
> sendToAllProcesses(Messages::WebProcess::DestroySession(PAL::SessionID::legacyPrivateSessionID()));

Ok.

>> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1482
>> +            weakThis->removePrevalentDomains(domainsToRemove);
> 
> Lambdas do not seem to make things better here.
> How about passing the weakThis once to WebResourceLoadStatisticsStore, which could then call the removePrevalentDomains/removeAllStorageAccessHandler/grantStorageAccessHandler/... methods directly.

This is a larger refactoring. I'll try and see how big it ends up being.

[Chris Dumez]

Created attachment 341793 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 341793 [details]
Patch

Clearing flags on attachment: 341793

Committed r232423: <https://trac.webkit.org/changeset/232423>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

*** Bug 186617 has been marked as a duplicate of this bug. ***

I still see that this issue is happening for all Safari browsers and it is not consistent, i.e. it send with most of GET requests but not all.

In two of our apps, we see that the request was not being sent with cookies at all for variety of requests including GET and POST.

Please fix this as it is very annoying and hard to detect.