Bug 186190

Summary: [GStreamer][MSE] MediaPlayerPrivateGStreamerMSE.h includes and forward declares PlaybackPipeline
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: WebCore Misc.Assignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eocanha, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews206 for win-future none

Description Xabier Rodríguez Calvar 2018-06-01 04:40:24 PDT 
Ideally we could use just the forward declaration and remove the header but I wanted to inline some code using that and it looks like removing the forward declaration does not work cause the include seems to do nothing.
Comment 1 Xabier Rodríguez Calvar 2018-06-04 07:28:39 PDT 
Created attachment 341902 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2018-06-04 07:30:05 PDT 
I just added this patch that I got from Enrique to fix this issue, I'll r+ myself if he agrees to get it landed.
Comment 3 Enrique Ocaña 2018-06-04 07:32:33 PDT 
Yes, please, go ahead.
Comment 4 EWS Watchlist 2018-06-04 12:40:43 PDT 
Comment on attachment 341902 [details]
Patch

Attachment 341902 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7979296

New failing tests:
http/tests/security/contentSecurityPolicy/video-with-https-url-allowed-by-csp-media-src-star.html
Comment 5 EWS Watchlist 2018-06-04 12:40:54 PDT 
Created attachment 341908 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 6 WebKit Commit Bot 2018-06-04 23:45:04 PDT 
Comment on attachment 341902 [details]
Patch

Clearing flags on attachment: 341902

Committed r232505: <https://trac.webkit.org/changeset/232505>
Comment 7 WebKit Commit Bot 2018-06-04 23:45:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-06-04 23:47:08 PDT 
<rdar://problem/40796784>