Bug 186167

Summary: [Cocoa] Web Automation: use the session delegate to perform window maximize
Product: WebKit Reporter: Blaze Burg <bburg>
Component: WebDriverAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, joepeck, thorton, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch timothy: review+

Blaze Burg
Reported 2018-05-31 16:41:24 PDT
Trying to do this from web APIs doesn't work well because of space needed for Dock. This is easier to do correctly on the browser side. And, some WebKit embedders may not have a notion of maximize, so doing it unconditionally doesn't make sense.
Attachments
Patch (10.28 KB, patch)
2018-05-31 16:48 PDT, Blaze Burg 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2018-05-31 16:41:47 PDT
<rdar://problem/40544391>
Blaze Burg
Comment 2 2018-05-31 16:48:01 PDT
Created attachment 341705 [details] Patch
EWS Watchlist
Comment 3 2018-05-31 16:51:26 PDT
Attachment 341705 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/Cocoa/AutomationSessionClient.mm:152: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Blaze Burg
Comment 4 2018-06-01 09:08:36 PDT
Committed r232396: <https://trac.webkit.org/changeset/232396>
Note You need to log in before you can comment on or make changes to this bug.