Bug 186150

Summary: Don't attempt to extend sandbox when running tests with mock media devices
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: MediaAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, commit-queue, eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 185526    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing none

Brent Fulgham
Reported 2018-05-31 10:33:22 PDT
Various WebKit media tests can fail when TCC prompts are displayed when WebKitTestRunner attempts to create sandbox extensions for media capture devices. When running our test infrastructure, we use Mock devices, which do not need these extensions, and should not be creating any prompts. This patch revises the media capture device logic to avoid extending the sandbox for mock test devices.
Attachments
Patch (2.18 KB, patch)
2018-05-31 10:41 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.22 KB, patch)
2018-05-31 10:49 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2018-05-31 10:41:06 PDT
Created attachment 341672 [details] Patch
Brent Fulgham
Comment 2 2018-05-31 10:49:06 PDT
<rdar://problem/40690875>
Brent Fulgham
Comment 3 2018-05-31 10:49:45 PDT
Created attachment 341673 [details] Patch for landing
WebKit Commit Bot
Comment 4 2018-05-31 12:13:41 PDT
Comment on attachment 341673 [details] Patch for landing Clearing flags on attachment: 341673 Committed r232360: <https://trac.webkit.org/changeset/232360>
WebKit Commit Bot
Comment 5 2018-05-31 12:13:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.